Re: [PATCH] rtc: stm32: remove incorrect #ifdef check
From: kernel test robot
Date: Wed Aug 09 2023 - 12:36:48 EST
Hi Arnd,
kernel test robot noticed the following build warnings:
[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on atorgue-stm32/stm32-next soc/for-next linus/master v6.5-rc5 next-20230809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/rtc-stm32-remove-incorrect-ifdef-check/20230801-190951
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link: https://lore.kernel.org/r/20230801105932.3738430-1-arnd%40kernel.org
patch subject: [PATCH] rtc: stm32: remove incorrect #ifdef check
config: x86_64-buildonly-randconfig-r003-20230809 (https://download.01.org/0day-ci/archive/20230810/202308100045.WeVD1ttk-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230810/202308100045.WeVD1ttk-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308100045.WeVD1ttk-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/rtc/rtc-stm32.c:903:12: warning: 'stm32_rtc_resume' defined but not used [-Wunused-function]
903 | static int stm32_rtc_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~
>> drivers/rtc/rtc-stm32.c:893:12: warning: 'stm32_rtc_suspend' defined but not used [-Wunused-function]
893 | static int stm32_rtc_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~
vim +/stm32_rtc_resume +903 drivers/rtc/rtc-stm32.c
4e64350f42e2ce Amelie Delaunay 2017-01-11 892
4e64350f42e2ce Amelie Delaunay 2017-01-11 @893 static int stm32_rtc_suspend(struct device *dev)
4e64350f42e2ce Amelie Delaunay 2017-01-11 894 {
4e64350f42e2ce Amelie Delaunay 2017-01-11 895 struct stm32_rtc *rtc = dev_get_drvdata(dev);
4e64350f42e2ce Amelie Delaunay 2017-01-11 896
9a6757eadc14f0 Amelie Delaunay 2017-07-06 897 if (rtc->data->has_pclk)
9a6757eadc14f0 Amelie Delaunay 2017-07-06 898 clk_disable_unprepare(rtc->pclk);
9a6757eadc14f0 Amelie Delaunay 2017-07-06 899
4e64350f42e2ce Amelie Delaunay 2017-01-11 900 return 0;
4e64350f42e2ce Amelie Delaunay 2017-01-11 901 }
4e64350f42e2ce Amelie Delaunay 2017-01-11 902
4e64350f42e2ce Amelie Delaunay 2017-01-11 @903 static int stm32_rtc_resume(struct device *dev)
4e64350f42e2ce Amelie Delaunay 2017-01-11 904 {
4e64350f42e2ce Amelie Delaunay 2017-01-11 905 struct stm32_rtc *rtc = dev_get_drvdata(dev);
4e64350f42e2ce Amelie Delaunay 2017-01-11 906 int ret = 0;
4e64350f42e2ce Amelie Delaunay 2017-01-11 907
9a6757eadc14f0 Amelie Delaunay 2017-07-06 908 if (rtc->data->has_pclk) {
9a6757eadc14f0 Amelie Delaunay 2017-07-06 909 ret = clk_prepare_enable(rtc->pclk);
9a6757eadc14f0 Amelie Delaunay 2017-07-06 910 if (ret)
9a6757eadc14f0 Amelie Delaunay 2017-07-06 911 return ret;
9a6757eadc14f0 Amelie Delaunay 2017-07-06 912 }
9a6757eadc14f0 Amelie Delaunay 2017-07-06 913
4e64350f42e2ce Amelie Delaunay 2017-01-11 914 ret = stm32_rtc_wait_sync(rtc);
cf33e911f500f6 Chuhong Yuan 2019-12-06 915 if (ret < 0) {
cf33e911f500f6 Chuhong Yuan 2019-12-06 916 if (rtc->data->has_pclk)
cf33e911f500f6 Chuhong Yuan 2019-12-06 917 clk_disable_unprepare(rtc->pclk);
4e64350f42e2ce Amelie Delaunay 2017-01-11 918 return ret;
cf33e911f500f6 Chuhong Yuan 2019-12-06 919 }
4e64350f42e2ce Amelie Delaunay 2017-01-11 920
4e64350f42e2ce Amelie Delaunay 2017-01-11 921 return ret;
4e64350f42e2ce Amelie Delaunay 2017-01-11 922 }
4e64350f42e2ce Amelie Delaunay 2017-01-11 923
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki