Re: [PATCH 1/2] dt-bindings: input: cirrus,cs40l50: Support for CS40L50
From: James Ogletree
Date: Wed Aug 09 2023 - 12:42:34 EST
> On Aug 9, 2023, at 1:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 08/08/2023 19:25, James Ogletree wrote:
>
>> Signed-off-by: James Ogletree <james.ogletree@xxxxxxxxxx>
>> ---
>> .../bindings/input/cirrus,cs40l50.yaml | 77 +++++++++++++++++++
>> MAINTAINERS | 9 +++
>> 2 files changed, 86 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml b/Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>> new file mode 100644
>> index 000000000000..5437c6beb1b3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>> @@ -0,0 +1,77 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/input/cirrus,cs40l50.yaml*__;Iw!!DQ3KfwI!2ioHhI2ig3axVRD-7MYqqT1LF_bitWe1l-B-FQDJfUX_EaTLrLmUnqtyDtEXCVE2cNozj7ODAF7f09JdwmjS9avyHs13Hiw$
>> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!DQ3KfwI!2ioHhI2ig3axVRD-7MYqqT1LF_bitWe1l-B-FQDJfUX_EaTLrLmUnqtyDtEXCVE2cNozj7ODAF7f09JdwmjS9avyeDxRunA$
>> +
>> +title: Cirrus Logic CS40L50 Advanced Haptic Driver
>
> Driver as "motor"? If yes, then ok. If "Linux Driver" then not.
The former, so keeping as-is.
>
>> +
>> + cirrus,external-boost:
>> + description:
>> + Bypass the CS40L50 boost converter.
>> +
>> + The amplifier on CS40L50 can be powered internally through the boost
>> + converter, or else can be powered using an external supply. If an
>> + external VA supply is used, the boost converter must be bypassed.
>> + type: boolean
>
> Isn't this property then conflicting with va-supply?
“VA" was intended to mean amplifier voltage, not analog voltage. I will remove “VA" to fix the ambiguity.
Best,
James Ogletree