Re: [PATCH v9 1/7] sign-file: use getopt_long_only for parsing input args
From: Greg KH
Date: Thu Aug 10 2023 - 01:47:52 EST
On Wed, Aug 09, 2023 at 10:52:04PM +0530, Shreenidhi Shedi wrote:
> - getopt_long_only gives an option to use long names for options, so
> using it here to make the app usage easier.
>
> - Use more easy to remember command line argument names
>
> - Introduce cmd_opts structure to ease the handling of command line args
When you have to list a number of different things that you did in a
single patch, that usually means this needs to be split up into multiple
changes.
Please do so here, you are converting to a different api (getopt_long)
and adding new arguments (with no documentation) at the same time, which
means this is an almost impossible change to review easily. Would you
want to review this?
thanks,
greg k-h