Re: [PATCH v3 1/2] dt-bindings: input: cirrus,cs40l50: Support for CS40L50

[Krzysztof Kozlowski]

On 09/08/2023 21:10, James Ogletree wrote:
> Introduce device tree bindings for the initial commit
> of the CS40L50 driver.
>

> +  va-supply:
> +    description: Regulator for analog voltage
> +
> +  vp-supply:
> +    description: Regulator for peak voltage
> +
> +  vio-supply:
> +    description: Regulator for digital IO voltage
> +
> +  cirrus,external-boost:
> +    description:
> +      Bypass the CS40L50 boost converter.
> +
> +      The amplifier on CS40L50 can be powered internally through the boost
> +      converter, or else can be powered using an external supply. If an
> +      external supply is used, the boost converter must be bypassed.
> +    type: boolean
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - reset-gpios

I would expect at least some supplies/regulators to be required. This
should match what the datasheet says. The rest looks good.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


Best regards,
Krzysztof