Re: [PATCH] rtc: stm32: remove incorrect #ifdef check
From: Alexandre Belloni
Date: Thu Aug 10 2023 - 03:22:35 EST
On Tue, 01 Aug 2023 12:59:15 +0200, Arnd Bergmann wrote:
> After a previous commit changed the driver over to
> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(), the suspend/resume
> functions must no longer be hidden behind an #ifdef:
>
> In file included from include/linux/clk.h:13,
> from drivers/rtc/rtc-stm32.c:8:
> drivers/rtc/rtc-stm32.c:927:39: error: 'stm32_rtc_suspend' undeclared here (not in a function); did you mean 'stm32_rtc_probe'?
> 927 | SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume)
> | ^~~~~~~~~~~~~~~~~
> include/linux/kernel.h:58:44: note: in definition of macro 'PTR_IF'
> 58 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
> | ^~~
> include/linux/pm.h:329:26: note: in expansion of macro 'pm_sleep_ptr'
> 329 | .suspend_noirq = pm_sleep_ptr(suspend_fn), \
> | ^~~~~~~~~~~~
>
> [...]
Applied, thanks!
[1/1] rtc: stm32: remove incorrect #ifdef check
commit: a69c610e13e2b2de8a1ed2683f13e21b3200bd7a
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com