Re: [PATCH] net: sfp: handle 100G/25G active optical cables in sfp_parse_support

[Josua Mayer]

Hi Russell,

Am 10.08.23 um 12:39 schrieb Russell King (Oracle):
> On Thu, Aug 10, 2023 at 11:48:17AM +0200, Josua Mayer wrote:
> > Handle extended compliance code 0x1 (SFF8024_ECC_100G_25GAUI_C2M_AOC)
> > for active optical cables supporting 25G and 100G speeds.
> Thanks. I think I would like one extra change:
>
> > +	case SFF8024_ECC_100G_25GAUI_C2M_AOC:
> >   	case SFF8024_ECC_100GBASE_SR4_25GBASE_SR:
> >   		phylink_set(modes, 100000baseSR4_Full);
> Since SFPs are single lane, SR4 doesn't make sense (which requires
> four lanes), and I shouldn't have added it when adding these modes.
> It would be a good idea to drop that, or at least for the
> addition of the SFF8024_ECC_100G_25GAUI_C2M_AOC case.
Would it be okay changing 100000baseSR4 to 100000baseSR dropping the "4"?


- Josua Mayer