Re: [PATCH 01/36] tty: xtensa/iss: drop unneeded tty_operations hooks

From: Max Filippov
Date: Thu Aug 10 2023 - 08:37:49 EST


On Thu, Aug 10, 2023 at 2:15 AM Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx> wrote:
>
> All ::flush_chars(), ::hangup(), and ::wait_until_sent() from struct
> tty_operations are optional. There is no need to provide them with
> empty bodies.
>
> tty_operations::put_char() needs not be provided if it is the same as
> tty_operations::write(tty, &ch, 1).
>
> So drop all of them.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> Cc: Chris Zankel <chris@xxxxxxxxxx>
> Cc: Max Filippov <jcmvbkbc@xxxxxxxxx>
> ---
> arch/xtensa/platforms/iss/console.c | 24 ------------------------
> 1 file changed, 24 deletions(-)

Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx>

--
Thanks.
-- Max