Re: [PATCH v2 02/11] ASoC: dt-bindings: mediatek,mt8188-mt6359: use common sound card

From: Rob Herring
Date: Thu Aug 10 2023 - 12:35:49 EST


On Thu, Aug 10, 2023 at 1:47 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 10/08/2023 09:20, Rob Herring wrote:
> >
> > On Thu, 10 Aug 2023 08:32:50 +0200, Krzysztof Kozlowski wrote:
> >> The mediatek,mt8188-mt6359 Linux sound machine driver requires the
> >> "model" property, so binding was incomplete. Reference the common sound
> >> card properties to fix that which also allows to remove duplicated
> >> property definitions. Leave the relevant parts of "audio-routing"
> >> description.
> >>
> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >> ---
> >> .../bindings/sound/mediatek,mt8188-mt6359.yaml | 17 +++++++----------
> >> 1 file changed, 7 insertions(+), 10 deletions(-)
> >>
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> >
>
> I think the bot responds like this if the patch could not be applied.
> Probably we can ignore it.

It's because I converted dtschema to use pyproject.toml (the newest
and 3rd way to do python packaging). I started getting deprecation
warnings on debian testing due to using setup.py. Converting breaks on
ubuntu 22.04. Seems to be this bug[1]. The CI job should now be fixed
by installing the latest pip version.

Rob

[1] https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/2018288