Re: [PATCH v9 net-next 16/23] net/tcp: Ignore specific ICMPs for TCP-AO connections

[Eric Dumazet]

On Thu, Aug 10, 2023 at 6:27 PM Dmitry Safonov <dima@xxxxxxxxxx> wrote:
>
> On 8/8/23 14:43, Eric Dumazet wrote:
> > On Wed, Aug 2, 2023 at 7:27 PM Dmitry Safonov <dima@xxxxxxxxxx> wrote:
> [..]
> >>
> >> +bool tcp_ao_ignore_icmp(struct sock *sk, int type, int code)
> >
> > const struct sock *sk ?
>
> Well, I can't really: atomic64_inc(&ao->counters.dropped_icmp)

I think we could, because this would still work.

 struct tcp_ao_info *ao; // This is rw object

ao = rcu_dereference(tcp_sk(sk)->ao_info);

This helper looks to accept unlocked sockets, so marking them const
would avoid mistakes in the future.