Re: [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()

[Alexandru Ardelean]

On Thu, Aug 10, 2023 at 2:23 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>

> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/thermal/k3_bandgap.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c
> index 1c3e590157ec..f985f36f2123 100644
> --- a/drivers/thermal/k3_bandgap.c
> +++ b/drivers/thermal/k3_bandgap.c
> @@ -225,7 +225,6 @@ static int k3_bandgap_probe(struct platform_device *pdev)
>                 devm_thermal_add_hwmon_sysfs(dev, data[id].tzd);
>         }
>
> -       platform_set_drvdata(pdev, bgp);
>
>         return 0;
>
> --
> 2.34.1
>