Re: [PATCH 2/2] gpio: sim: simplify code with cleanup helpers

[Andy Shevchenko]

On Thu, Aug 10, 2023 at 09:04:12PM +0200, Bartosz Golaszewski wrote:
> On Thu, Aug 10, 2023 at 4:42 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Wed, Aug 09, 2023 at 03:14:42PM +0200, Bartosz Golaszewski wrote:

...

> > > +     scoped_guard(mutex, &chip->lock)
> > > +             bitmap_replace(chip->value_map, chip->value_map, bits, mask,
> > > +                            gc->ngpio);
> >
> > Perhaps with {} ?
> 
> This scoped_guard() thing is in essence a for loop, so I believe
> kernel coding style applies and a single statement doesn't require a
> {}.

You have two lines (or single wrapped line). I found to read it better with {}.

-- 
With Best Regards,
Andy Shevchenko