Re: [PATCH] serial: core: Fix serial core port id, including multiport devices

[Andy Shevchenko]

On Fri, Aug 11, 2023 at 08:11:21AM +0300, Tony Lindgren wrote:
> * Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> [230810 15:26]:
> > On Thu, Aug 10, 2023 at 06:24:13PM +0300, Andy Shevchenko wrote:
> > > On Thu, Aug 10, 2023 at 09:57:34AM +0300, Tony Lindgren wrote:

...

> > > > +	unsigned int min = 0, max = ~0U;
> > > 
> > > Shouldn't this be int? The max IIRC will be INT_MAX with this anyway.
> > 
> > Ah, and then you can supply is as 0 (IIRC).
> 
> The returned id will be INT_MAX, but idr.h uses unsigned int:
> 
> int ida_alloc_range(struct ida *, unsigned int min, unsigned int max, gfp_t);
> 
> If there's some reason to limit max id we can do it, otherwise it's just
> a don't care flag.
> 
> Please clarify if I'm not following what you are suggesting :)

	... max = 0;

Will have the same effect with more explicit intention "use whatever maximum is
default". With ~0U I would expect to see something bigger than INT_MAX, but it
won't ever appear.

-- 
With Best Regards,
Andy Shevchenko