Re: [PATCH 2/4] perf vendor events arm64: AmpereOne: Mark affected STALL_* events impacted by errata

[John Garry]

On 10/08/2023 23:38, Ilkka Koskinen wrote:
> > > why end with a '-'?
> >
> > That's a great question! I wish, I remembered why I did that. Looking 
> > at other events with Errata field, they use '.'. I can fix those and 
> > submit the patchset again.
>
> John, I took a look at it and it seems that if I use '.', perf will 
> remove it. Here are two examples:
>
> metrics.json:
> "BriefDescription": "Impacted by errata, use metrics instead."
>
> # perf list
> [Impacted by errata, use metrics instead Spec update: Errata AC03_CPU_29]
>
> vs.
>
> "BriefDescription": "Impacted by errata, use metrics instead -"
>
> # perf list
>
> Impacted by errata, use metrics instead - Spec update: Errata AC03_CPU_29

ah, ok. I am not sure where the '.' removal is coming from.

> ---
>
> So, I believe, I probably used the hyphen to make the 'perf list' output 
> a little "prettier". Well, I just change to dot and it's fine.

Fine. Or we could consider changing the 'perf list' formatting code to 
add this '-' or similar automatically.

Thanks,
John