Re: [PATCH v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load

[Guenter Roeck]

On 8/11/23 05:02, Raag Jadav wrote:
> When built with CONFIG_INTEL_MID_WATCHDOG=m, currently the driver
> needs to be loaded manually, for the lack of module alias.
> This causes unintended resets in cases where watchdog timer is
> set-up by bootloader and the driver is not explicitly loaded.
> Add MODULE_ALIAS() to load the driver automatically at boot and
> avoid this issue.
>
> Fixes: 87a1ef8058d9 ("watchdog: add Intel MID watchdog driver support")
> Signed-off-by: Raag Jadav <raag.jadav@xxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>   drivers/watchdog/intel-mid_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 9b2173f765c8..fb7fae750181 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -203,3 +203,4 @@ module_platform_driver(mid_wdt_driver);
>   MODULE_AUTHOR("David Cohen <david.a.cohen@xxxxxxxxxxxxxxx>");
>   MODULE_DESCRIPTION("Watchdog Driver for Intel MID platform");
>   MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:intel_mid_wdt");