Re: [PATCH v2 6/6] bitmap: move bitmap_*_region functions to bitmap.h

From: Yury Norov
Date: Fri Aug 11 2023 - 09:06:22 EST


On Fri, Aug 11, 2023 at 12:27:51PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 10, 2023 at 05:57:32PM -0700, Yury Norov wrote:
> > Now that bitmap_*_region() functions are implemented as thin wrappers
> > around others, it's worth to move them to the header, as it opens room
> > for compile-time optimizations.
>
> ...
>
> > + * Return 0 on success, or %-EBUSY if specified region wasn't
> > + * free (not all bits were zero).
>
> Run
>
> scripts/kernel-doc -v -none -Wall
> ...
>
> Seems like the original code has all these, perhaps update in a separate patch?

Yes. This patch is named _move_, which means - I don't touch the code.
I already replaced (1U << order) to BIT(order), and I'm not happy with
that. We need to do that in a separate patch.

Thanks,
Yury