Re: [PATCH] dt-bindings: Convert the sti pin controller bindings to YAML

From: Rob Herring
Date: Fri Aug 11 2023 - 10:01:10 EST

Next message: Rob Herring: "Re: [PATCH 1/2] dt-bindings: input: gpio-keys: Allow optional dedicated wakeirq"
Previous message: Rob Herring: "Re: [PATCH v9 12/13] media: dt-bindings: Add TI J721E CSI2RX"
In reply to: Linus Walleij: "[PATCH] dt-bindings: Convert the sti pin controller bindings to YAML"
Next in thread: Rob Herring: "Re: [PATCH] dt-bindings: Convert the sti pin controller bindings to YAML"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, 10 Aug 2023 23:53:17 +0200, Linus Walleij wrote:
> This rewrites the STi pin control bindings to use YAML.
>
> These bindings came early in the development of pin control
> bindings so they are a bit obscure, and required a bit of
> uncommon regexp work.
>
> The reason why these bindings need to be converted and
> preserved can be seen in the two new added compatibles,
> which are for the SpaceX Starlink chip "gllcff" which uses
> a derivative of this pin controller.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> .../devicetree/bindings/pinctrl/pinctrl-st.txt | 174 ---------------
> .../bindings/pinctrl/st,sti-pinctrl.yaml | 238 +++++++++++++++++++++
> 2 files changed, 238 insertions(+), 174 deletions(-)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
group: size (9) error for type phandle-array
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/brcm,bcm6362-pinctrl.example.dtb: nand-pins: group: b'nand_grp\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
group: size (9) error for type phandle-array
pin: size (7) error for type phandle-array
group: size (11) error for type phandle-array
group: size (10) error for type phandle-array
group: size (10) error for type phandle-array
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/brcm,bcm63268-pinctrl.example.dtb: nand-pins: group: b'nand_grp\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/brcm,bcm63268-pinctrl.example.dtb: gpio35_alt-pins: pin: b'gpio35\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/brcm,bcm63268-pinctrl.example.dtb: dectpd-pins: group: b'dectpd_grp\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/brcm,bcm63268-pinctrl.example.dtb: dsl_gpio8-pins: group: b'dsl_gpio8\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/brcm,bcm63268-pinctrl.example.dtb: dsl_gpio9-pins: group: b'dsl_gpio9\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
group: size (10) error for type phandle-array
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/brcm,bcm6368-pinctrl.example.dtb: uart1-pins: group: b'uart1_grp\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/afe/temperature-transducer.example.dtb: temperature-sensor-0: sense-offset-millicelsius: 'anyOf' conditional failed, one must be fixed:
4294694146 is greater than the maximum of 2147483647
from schema $id: http://devicetree.org/schemas/property-units.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/afe/temperature-transducer.example.dtb: temperature-sensor-1: sense-offset-millicelsius: 'anyOf' conditional failed, one must be fixed:
4294694146 is greater than the maximum of 2147483647
from schema $id: http://devicetree.org/schemas/property-units.yaml#
group: size (9) error for type phandle-array
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/brcm,bcm6362-gpio-sysctl.example.dtb: nand-pins: group: b'nand_grp\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
group: size (9) error for type phandle-array
pin: size (7) error for type phandle-array
group: size (11) error for type phandle-array
group: size (10) error for type phandle-array
group: size (10) error for type phandle-array
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.example.dtb: nand-pins: group: b'nand_grp\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.example.dtb: gpio35_alt-pins: pin: b'gpio35\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.example.dtb: dectpd-pins: group: b'dectpd_grp\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.example.dtb: dsl_gpio8-pins: group: b'dsl_gpio8\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/brcm,bcm63268-gpio-sysctl.example.dtb: dsl_gpio9-pins: group: b'dsl_gpio9\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
group: size (10) error for type phandle-array
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/brcm,bcm6368-gpio-sysctl.example.dtb: uart1-pins: group: b'uart1_grp\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/sc27xx-fg.example.dtb: battery: ocv-capacity-table-0:0: [4185000, 100, 4113000, 95, 4066000, 90, 4022000, 85, 3983000, 80, 3949000, 75, 3917000, 70, 3889000, 65, 3864000, 60, 3835000, 55, 3805000, 50, 3787000, 45, 3777000, 40, 3773000, 35, 3770000, 30, 3765000, 25, 3752000, 20, 3724000, 15, 3680000, 10, 3605000, 5, 3400000, 0] is too long
from schema $id: http://devicetree.org/schemas/power/supply/battery.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/battery.example.dtb: battery: ocv-capacity-table-0:0: [4185000, 100, 4113000, 95, 4066000, 90] is too long
from schema $id: http://devicetree.org/schemas/power/supply/battery.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/battery.example.dtb: battery: ocv-capacity-table-1:0: [4200000, 100, 4185000, 95, 4113000, 90] is too long
from schema $id: http://devicetree.org/schemas/power/supply/battery.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/battery.example.dtb: battery: ocv-capacity-table-2:0: [4250000, 100, 4200000, 95, 4185000, 90] is too long
from schema $id: http://devicetree.org/schemas/power/supply/battery.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/battery.example.dtb: battery: ocv-capacity-celsius: 'anyOf' conditional failed, one must be fixed:
[4294967286, 0, 10] is too long
4294967286 is greater than the maximum of 2147483647
from schema $id: http://devicetree.org/schemas/property-units.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/battery.example.dtb: battery: operating-range-celsius: 'anyOf' conditional failed, one must be fixed:
[4294967266, 50] is too long
4294967266 is greater than the maximum of 2147483647
from schema $id: http://devicetree.org/schemas/property-units.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/battery.example.dtb: battery: ambient-celsius: 'anyOf' conditional failed, one must be fixed:
[4294967291, 50] is too long
4294967291 is greater than the maximum of 2147483647
from schema $id: http://devicetree.org/schemas/property-units.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810-dt-bindings-sti-v1-1-4f73ffc37d87@xxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Next message: Rob Herring: "Re: [PATCH 1/2] dt-bindings: input: gpio-keys: Allow optional dedicated wakeirq"
Previous message: Rob Herring: "Re: [PATCH v9 12/13] media: dt-bindings: Add TI J721E CSI2RX"
In reply to: Linus Walleij: "[PATCH] dt-bindings: Convert the sti pin controller bindings to YAML"
Next in thread: Rob Herring: "Re: [PATCH] dt-bindings: Convert the sti pin controller bindings to YAML"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]