Re: [PATCH 1/2] iio: lsm6dsx: Support temperature channel

[Linus Walleij]

Hi Lorenzo!

thanks for the review!

On Fri, Aug 11, 2023 at 12:07 PM Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote:

> > +                     [ST_LSM6DSX_ID_TEMP] = {
> > +                             .reg = {
> > +                                     .addr = 0x0A,
> > +                                     .mask = GENMASK(5, 4),
> > +                             },
>
> looking at the ISM330DHCX datasheet, the temperature sensor ODR is just 52Hz,
> while values in 0x0A register are used only for FIFO decimation, they are not
> values you can configure the sensor e.g. for read_one_shot().
>
> > +                             .odr_avl[0] = {  26000, 0x02 },
> > +                             .odr_avl[1] = {  52000, 0x03 },
> > +                             .odr_len = 2,

I look at page 44, paragraph 9.6 about bits 4-5:

ODR_T_BATCH_[1:0]
Selects batch data rate (write frequency in FIFO) for temperature data
(00: Temperature not batched in FIFO (default);
01: 1.6 Hz;
10: 12.5 Hz;
11: 52 Hz)

That reads to me that I should actually add the odr for 1.6 and 12.5 Hz
and the above 26 Hz is wrong but the .odr_avl[1] = {  52000, 0x03 },
52000 milli-Hz is fine?

Yours,
Linus Walleij