Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node with bindings

[Konrad Dybcio]

On 11.08.2023 23:01, Robert Marko wrote:
> Rename the SPI-NOR node to flash@0, remove #address-cells and #size-cells
> as they should be under the partitions subnode and use the generic
> jedec,spi-nor compatible.
> 
> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
> ---
You can also do "nandmanufacturer,mx25l25635e", "jedec,spi-nor"

Konrad

>  arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi b/arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi
> index 0714616c9e45..f7ac8f9d0b6f 100644
> --- a/arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi
> @@ -75,11 +75,9 @@ &blsp1_spi1 {
>  	status = "okay";
>  	cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
>  
> -	mx25l25635e@0 {
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> +	flash@0 {
>  		reg = <0>;
> -		compatible = "mx25l25635e";
> +		compatible = "jedec,spi-nor";
>  		spi-max-frequency = <24000000>;
>  	};
>  };