Re: [PATCH 2/7] ARM: dts: qcom: add common device tree for MSM8x26-based Lumia phones

[Konrad Dybcio]

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add a common device tree for Lumias based on the Qualcomm MSM8x26
> family of chipsets.
> 
> Currently supports:
> - Framebuffer
> - Touchscreen
> - Keys
> - Regulators
> - MMC
> - USB
> - UART
> 
> Co-authored-by: Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> Co-authored-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> Co-authored-by: Jack Matthews <jm5112356@xxxxxxxxx>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> Signed-off-by: Jack Matthews <jm5112356@xxxxxxxxx>
> Signed-off-by: Rayyan Ansari <rayyan@xxxxxxxxx>
> ---
Would be really nice if you could squash it with patch 3 so that
this code is immediately compilable.

[...]

> +	gpio_keys: gpio-keys {
> +		compatible = "gpio-keys";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&gpio_keys_active>;
property-n
property-names

[...]

> +	reserved-memory {
> +		ranges;
That's already there in soc dtsi

> +
> +		smem_region: smem@fa00000 {
Swap the subnodes to keep the nodes ordered by unit address
> +			reg = <0xfa00000 0x100000>;
> +			no-map;
> +		};
> +
> +		display_reserved: framebuffer@3200000 {
> +			reg = <0x3200000 0x800000>;
> +			no-map;
> +		};
> +	};
> +};
> +
> +&blsp1_i2c5 {
> +	status = "okay";
> +
> +	touchscreen@4b {
> +		compatible = "syna,rmi4-i2c";
> +		reg = <0x4b>;
> +
> +		interrupts-extended = <&tlmm 17 IRQ_TYPE_EDGE_FALLING>;
> +		vdd-supply = <&pm8226_l15>;
> +		vio-supply = <&pm8226_l6>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&touchscreen_on>;
ditto

> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		rmi4-f01@1 {
> +			reg = <0x01>;
> +			syna,nosleep-mode = <1>;
> +		};
> +
> +		rmi4-f11@11 {
> +			reg = <0x11>;
> +			syna,sensor-type = <1>;
> +		};
> +	};
> +};
[...]

> +
> +&tlmm {
> +	gpio_keys_active: gpio-keys-active {
Run `make CHECK_DTBS=1 qcom/msm8226-something-lumia` and fix the warnings
before Krzysztof gets angry :D

Konrad