Re: [PATCH 7/7] ARM: dts: qcom: add device tree for Nokia Lumia 830

From: Konrad Dybcio
Date: Fri Aug 11 2023 - 19:07:20 EST


On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add an initial device tree for the Nokia Lumia 830, codenamed
> "tesla".
>
> Co-authored-by: Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> Co-authored-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> Co-authored-by: Jack Matthews <jm5112356@xxxxxxxxx>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> Signed-off-by: Jack Matthews <jm5112356@xxxxxxxxx>
> Signed-off-by: Rayyan Ansari <rayyan@xxxxxxxxx>
> ---
> arch/arm/boot/dts/qcom/Makefile | 1 +
> .../dts/qcom/qcom-msm8926-microsoft-tesla.dts | 66 +++++++++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
>
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index 7982620ec9f9..a3d293e40820 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-msm8916-samsung-grandmax.dtb \
> qcom-msm8916-samsung-serranove.dtb \
> qcom-msm8926-microsoft-superman-lte.dtb \
> + qcom-msm8926-microsoft-tesla.dtb \
> qcom-msm8960-cdp.dtb \
> qcom-msm8960-samsung-expressatt.dtb \
> qcom-msm8974-lge-nexus5-hammerhead.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
> new file mode 100644
> index 000000000000..5a4f4687b895
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-tesla.dts
> @@ -0,0 +1,66 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Jack Matthews <jm5112356@xxxxxxxxx>
> + * Copyright (c) 2023, Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> + * Copyright (c) 2023, Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> + * Copyright (c) 2023, Rayyan Ansari <rayyan@xxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226-microsoft-common.dtsi"
> +
> +/ {
> + model = "Nokia Lumia 830";
> + compatible = "microsoft,tesla", "qcom,msm8926";
> + chassis-type = "handset";
> +};
> +
> +&blsp1_i2c1 {
> + status = "okay";
> +
> + touchscreen@4b {
> + compatible = "syna,rmi4-i2c";
> + reg = <0x4b>;
> +
> + interrupts-extended = <&tlmm 17 IRQ_TYPE_EDGE_FALLING>;
> + vdd-supply = <&pm8226_l15>;
> + vio-supply = <&pm8226_l6>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchscreen_on>;
flip

Konrad
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rmi4-f01@1 {
> + reg = <0x01>;
> + syna,nosleep-mode = <1>;
> + };
> +
> + rmi4-f12@12 {
> + reg = <0x12>;
> + syna,sensor-type = <1>;
> + };
> + };
> +};
> +
> +&blsp1_i2c5 {
> + status = "disabled";
> +
> + /delete-node/ touchscreen@4b;
> +};
> +
> +&gpio_keys {
> + camera-snapshot {
> + label = "Camera Snapshot";
> + gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_CAMERA>;
> + };
> +
> + camera-focus {
> + label = "Camera Focus";
> + gpios = <&tlmm 108 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_CAMERA_FOCUS>;
> + };
> +};