Re: [patch V3 23/40] x86/cpu: Provide cpu_init/parse_topology()

[Zhang, Rui]

> +
> +static inline u32 topo_relative_domain_id(u32 apicid, enum
> x86_topology_domains dom)
> +{
> +       if (dom != TOPO_SMT_DOMAIN)
> +               apicid >>= x86_topo_system.dom_shifts[dom - 1];
> +       return apicid & (x86_topo_system.dom_size[dom] - 1);
> +}

relative_domain_id() is used to get a unique id value within its next
higher level.

> +static void topo_set_ids(struct topo_scan *tscan)
> +{
> +       struct cpuinfo_x86 *c = tscan->c;
> +       u32 apicid = c->topo.apicid;
> +
> +       c->topo.pkg_id = topo_shift_apicid(apicid, TOPO_PKG_DOMAIN);
> +       c->topo.die_id = topo_shift_apicid(apicid, TOPO_DIE_DOMAIN);
> +
> +       /* Relative core ID */
> +       c->topo.core_id = topo_relative_domain_id(apicid,
> TOPO_CORE_DOMAIN);

My understanding is that, to ensure a package scope unique core_id,
rather than Module/Tile scope unique, what is really needed here is
something like,
	apicid >>= x86_topo_system.dom_shifts[SMT];
	c->topo.core_id = apicid & (x86_topo_system.dom_size[PACKAGE]
- 1);

I don't have chance to confirm this on a platform with Module level
yet, but will do soon.

thanks,
rui