Re: [PATCH] thermal: sun8i_thermal: remove unneeded call to platform_set_drvdata()

[Jernej Škrabec]

Dne petek, 11. avgust 2023 ob 21:40:32 CEST je Andrei Coardos napisal(a):
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
> 
> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>

Reviewed-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>

Best regards,
Jernej

> ---
>  drivers/thermal/sun8i_thermal.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/thermal/sun8i_thermal.c
> b/drivers/thermal/sun8i_thermal.c index 195f3c5d0b38..61a2f287ac90 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -489,8 +489,6 @@ static int sun8i_ths_probe(struct platform_device *pdev)
> if (!tmdev->chip)
>  		return -EINVAL;
> 
> -	platform_set_drvdata(pdev, tmdev);
> -
>  	ret = sun8i_ths_resource_init(tmdev);
>  	if (ret)
>  		return ret;