Re: [PATCH 0/3] md raid1: Fix writebehind/writemostly
From: Song Liu
Date: Sun Aug 13 2023 - 13:58:53 EST
On Thu, Aug 10, 2023 at 4:12 PM <heinzm@xxxxxxxxxx> wrote:
>
> From: heinzm <heinzm@xxxxxxxxxx>
>
> Writemostly was only respected if set on the first leg.
>
> Set on any other leg(s) but not on the first one did
> not enable writebehind at all.
>
> Fix changes the logic using the already defind bool writebehind.
>
> Whilst on this, also make first_clone a bool as write_behind for
> consistency and add an empty line.
>
> Patches pass the MD test suite.
>
> heinzm (3):
> md raid1: allow writebehind to work on any leg device set WriteMostly
1/3 looks good. But please resend with your full name.
> md raid1: make first_clone a bool
> md raid1: add empty line
2/3 and 3/3 are not necessary. I would rather keep git-blame clean.
Thanks,
Song
>
> Signed-off-by: Heinz Mauelshagen <heinzm@xxxxxxxxxx>
> Tested-by: Xia Ni <xni@xxxxxxxxxx>
>
> drivers/md/raid1.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> --
> 2.41.0
>