Re: [PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs

[Andrew Lunn]

On Sun, Aug 13, 2023 at 06:17:11PM +0100, Daniel Golle wrote:
> Hi Andrew,
> 
> thank you for reviewing my patch!
> 
> On Sun, Aug 13, 2023 at 07:03:21PM +0200, Andrew Lunn wrote:
> > Hi Daniel
> > 
> > > This requires syscon phandle 'mediatek,pio' present in parenting MDIO bus
> > > which should point to the syscon holding the boottrap register.
> > 
> > If i'm reading the code correct, if this property is missing, the PHY
> > will fail to probe? Since this was never a mandatory property, it
> > looks like this will break old DT blobs?
> 
> As the for-upstream-Linux dtsi for the MediaTek MT7988 SoC is still in
> the making there aren't any existing DT blobs we'd want to be compatible
> with at this point.

Ah. O.K. If there is need for a respin, please add that to the commit
message.

	Andrew