Re: [PATCH] thermal: mediatek: auxadc_thermal: removed call to platform_set_drvdata()

[Alexandru Ardelean]

On Fri, Aug 11, 2023 at 10:28 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>

> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/thermal/mediatek/auxadc_thermal.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> index f59d36de20a0..99a1c35c68e7 100644
> --- a/drivers/thermal/mediatek/auxadc_thermal.c
> +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> @@ -1283,8 +1283,6 @@ static int mtk_thermal_probe(struct platform_device *pdev)
>                         mtk_thermal_init_bank(mt, i, apmixed_phys_base,
>                                               auxadc_phys_base, ctrl_id);
>
> -       platform_set_drvdata(pdev, mt);
> -
>         tzdev = devm_thermal_of_zone_register(&pdev->dev, 0, mt,
>                                               &mtk_thermal_ops);
>         if (IS_ERR(tzdev))
> --
> 2.34.1
>