Re: [PATCH] thermal: max77620_thermal: removed unneeded call to platform_set_drvdata()

[Alexandru Ardelean]

On Fri, Aug 11, 2023 at 10:16 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

I was (at first) tempted to say that this may be reduced to "return
devm_request_threaded_irq(...)", but after a while, I thought that
this is quite fine on it's own.
Just removing the 'platform_set_drvdata(...)' does add a bit of neat
symmetry to the code.

So

Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>


> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/thermal/max77620_thermal.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/thermal/max77620_thermal.c b/drivers/thermal/max77620_thermal.c
> index 61c7622d9945..919b6ee208d8 100644
> --- a/drivers/thermal/max77620_thermal.c
> +++ b/drivers/thermal/max77620_thermal.c
> @@ -139,8 +139,6 @@ static int max77620_thermal_probe(struct platform_device *pdev)
>                 return ret;
>         }
>
> -       platform_set_drvdata(pdev, mtherm);
> -
>         return 0;
>  }
>
> --
> 2.34.1
>