Re: [PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs

[Andrew Lunn]

On Sun, Aug 13, 2023 at 08:04:29PM +0100, Daniel Golle wrote:
> On Sun, Aug 13, 2023 at 08:57:01PM +0200, Andrew Lunn wrote:
> > On Sun, Aug 13, 2023 at 05:24:55PM +0100, Daniel Golle wrote:
> > > Implement netdev trigger and primitive bliking offloading as well as
> > > simple set_brigthness function for both PHY LEDs of the in-SoC PHYs
> > > found in MT7981 and MT7988.
> > > 
> > > For MT7988, read boottrap register and apply LED polarities accordingly
> > 
> > Should this be bootstrap? With an S? boottrap appears quite often in
> > the code, so maybe the datasheet does say boottrap?
> 
> Yes, datasheet and vendor code refer to boottrap register which reflects
> the state of the pins used for bootStrapping the SoC...

O.K. So following the datasheet makes sense.

Again, if there is need for a respin, maybe add a comment next to the
#define.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew