Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp counter atomic update feature

[Sai Krishna Gajula]

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Saturday, August 12, 2023 3:35 AM
> To: Sai Krishna Gajula <saikrishnag@xxxxxxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Sunil Kovvuri
> Goutham <sgoutham@xxxxxxxxxxx>; Geethasowjanya Akula
> <gakula@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta
> <sbhatta@xxxxxxxxxxx>; Hariprasad Kelam <hkelam@xxxxxxxxxxx>;
> richardcochran@xxxxxxxxx; Naveen Mamindlapalli
> <naveenm@xxxxxxxxxxx>
> Subject: Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp
> counter atomic update feature
> 
> On Fri, 11 Aug 2023 05:48:38 +0000 Sai Krishna Gajula wrote:
> > > If you reorder the includes - maybe put them in alphabetical order?
> >
> > There are some structure definitions in rvu.h which are required in
> > ptp.h. So, re-ordering in alphabetical order will give compilation
> > issue.
> 
> Headers should be self-contained. Such dependencies are hard to figure out
> for people doing refactoring so it'd be best to clean that up.

Ack, will fix the dependencies and keep the headers in alphabetical order in V3 patch.

Thanks,
Sai