Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller

[Andre Przywara]

On Mon, 14 Aug 2023 12:28:36 +0200
Jernej Škrabec <jernej.skrabec@xxxxxxxxx> wrote:

> Dne ponedeljek, 14. avgust 2023 ob 10:21:49 CEST je Martin Botka napisal(a):
> > On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski
> > 
> > <krzysztof.kozlowski@xxxxxxxxxx> wrote:  
> > > On 14/08/2023 08:38, Martin Botka wrote:  
> > >>  Add binding for the SID controller found in H616 SoC
> > >>  
> > >>  Signed-off-by: Martin Botka <martin.botka@xxxxxxxxxxxxxx>
> > >>  ---
> > >> 
> > >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> 
> > >> | 1 +
> > >> | 
> > >>   1 file changed, 1 insertion(+)
> > >>  
> > >>  diff --git
> > >> 
> > >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> 
> > >>  index 296001e7f498..2ec0a1b8f803 100644
> > >>  ---
> > >> 
> > >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> 
> > >>  +++
> > >> 
> > >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> 
> > >>  @@ -27,6 +27,7 @@ properties:
> > >>             - const: allwinner,sun50i-a64-sid
> > >>         
> > >>         - const: allwinner,sun50i-h5-sid
> > >>         - const: allwinner,sun50i-h6-sid
> > >>  
> > >>  +      - const: allwinner,sun50i-h616-sid  
> > > 
> > > It does not look like you tested the DTS against bindings. Please run
> > > `make dtbs_check` (see
> > > Documentation/devicetree/bindings/writing-schema.rst or
> > > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sour
> > > ces-with-the-devicetree-schema/ for instructions).
> > > 
> > > Best regards,
> > > Krzysztof  
> > 
> > Yea completely forgot. Sorry for that.
> > 
> > Will send v3 tomorrow with proper binding patch using items with enums  
> 
> Don't. You have cca. 1 month time now, since you missed at least window for DT 
> changes for 6.6.

Plus we need to figure out if my comment about using a fallback compatible
was actually correct, as asked here:
https://lore.kernel.org/linux-arm-kernel/20230811234212.2236c814@xxxxxxxxxxxx/

Cheers,
Andre