RE: [PATCH] Add Silicom Platform Driver

[Huibin Shi]

-----Original Message-----
From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck
Sent: Thursday, August 10, 2023 2:00 PM
To: Huibin Shi <henrys@xxxxxxxxxxxxxxx>; Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Cc: tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; bp@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; hpa@xxxxxxxxx; hdegoede@xxxxxxxxxx; markgross@xxxxxxxxxx; jdelvare@xxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; linux-hwmon@xxxxxxxxxxxxxxx; hb_shi2003@xxxxxxxxx; Wen Wang <wenw@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Add Silicom Platform Driver

Caution: This is an external email. Please take care when clicking links or opening attachments.


On 8/10/23 10:48, Huibin Shi wrote:
> Ilpo,
>
> See my comments below.
>
> Thanks.
> Henry
> ----Original Message-----
> From: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Sent: Thursday, August 3, 2023 8:07 AM
> To: Huibin Shi <henrys@xxxxxxxxxxxxxxx>
> Cc: tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; bp@xxxxxxxxx; 
> dave.hansen@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; hpa@xxxxxxxxx; 
> hdegoede@xxxxxxxxxx; markgross@xxxxxxxxxx; jdelvare@xxxxxxxx; 
> linux@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; 
> platform-driver-x86@xxxxxxxxxxxxxxx; linux-hwmon@xxxxxxxxxxxxxxx; 
> hb_shi2003@xxxxxxxxx; Wen Wang <wenw@xxxxxxxxxxxxxxx>
> Subject: RE: [PATCH] Add Silicom Platform Driver
>
> Caution: This is an external email. Please take care when clicking links or opening attachments.
>
>
> On Fri, 28 Jul 2023, Huibin Shi wrote:
>
>> Ilpo,
>>
>> Thanks for the comments. See my comments below.
>>
>> Updated patch will be sent out later after review comments from other reviewer are addressed.
>>
>> Henry
>> -----Original Message-----
>> From: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
>> Sent: Wednesday, July 19, 2023 8:13 AM
>> To: Henry Shi <henryshi2018@xxxxxxxxx>
>> Cc: hbshi69@xxxxxxxxxxx; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; 
>> bp@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; 
>> hpa@xxxxxxxxx; hdegoede@xxxxxxxxxx; markgross@xxxxxxxxxx; 
>> jdelvare@xxxxxxxx; linux@xxxxxxxxxxxx; LKML 
>> <linux-kernel@xxxxxxxxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx;
>> linux-hwmon@xxxxxxxxxxxxxxx; hb_shi2003@xxxxxxxxx; Huibin Shi 
>> <henrys@xxxxxxxxxxxxxxx>; Wen Wang <wenw@xxxxxxxxxxxxxxx>
>> Subject: Re: [PATCH] Add Silicom Platform Driver
>>
>> Caution: This is an external email. Please take care when clicking links or opening attachments.
>>
>>
>> On Tue, 18 Jul 2023, Henry Shi wrote:
>>
>>> The Silicom platform (silicom-platform) Linux driver for Swisscom 
>>> Business Box (Swisscom BB) as well as Cordoba family products is a 
>>> software solution designed to facilitate the efficient management 
>>> and control of devices through the integration of various Linux 
>>> frameworks. This platform driver provides seamless support for 
>>> device management via the Linux LED framework, GPIO framework, 
>>> Hardware Monitoring (HWMON), and device attributes. The Silicom 
>>> platform driver's compatibility with these Linux frameworks allows 
>>> applications to access and control Cordoba family devices using 
>>> existing software that is compatible with these frameworks. This 
>>> compatibility simplifies the development process, reduces 
>>> dependencies on proprietary solutions, and promotes interoperability 
>>> with other Linux-based systems and software.
>>>
>>> Signed-off-by: Henry Shi <henryshi2018@xxxxxxxxx>
>>> ---
>>>   drivers/platform/x86/Kconfig            |   12 +
>>>   drivers/platform/x86/Makefile           |    1 +
>>>   drivers/platform/x86/silicom-platform.c | 1123
>>> +++++++++++++++++++++++
>>>   3 files changed, 1136 insertions(+)  create mode 100644 
>>> drivers/platform/x86/silicom-platform.c
>>>
>
>>> +void lock_io_modules(void)
>>> +{
>>> +     mutex_lock(&mec_io_mutex);
>>> +}
>>> +EXPORT_SYMBOL(lock_io_modules);
>>> +
>>> +void unlock_io_modules(void)
>>> +{
>>> +     mutex_unlock(&mec_io_mutex);
>>> +}
>>> +EXPORT_SYMBOL(unlock_io_modules);
>
> These are unused.
>
> Henry: This will be used by another Silicom driver, which source code is not pushed to kernel repository.
>

Not an argument. Export it if and when needed. If that other driver won't be sent upstream, the export should not be upstream either.

Henry: OK, will remove these two EXPORT function

Guenter