Re: [PATCH V3] scsi: ufs: qcom: Align programming sequence as per HW spec

[Nitin Rawat]

Hi Bjorn,

I've updated the commit message in latest Patchset. Please can you help 
review.

Regards,
Nitin


On 8/10/2023 8:11 PM, Bjorn Andersson wrote:
> On Wed, Aug 09, 2023 at 08:42:43PM +0530, Nitin Rawat wrote:
> > Align clock configuration as per Qualcomm UFS controller
> > hardware specification.
> >
> > This change updates UFS_SYS1CLK_1US, CORE_CLK_1US_CYCLES,
> > PA_VS_CORE_CLK_40NS_CYCLES timer configuration for Qunipro
> > and UTP to align with Qualcomm UFS HW specification.
>
> "Code is wrong, make code right"
>
>
> I find it hard to believe that "the clock configuration is wrong" takes
> 207 lines of code to address.
>
> Please instead describe the problem you're solving, to ensure that
> current and future readers of this commit message have a chance to
> understand why this change was made.
>
> The "describing your changes" section in the documentation is good,
> please read it:
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
>
> Regards,
> Bjorn