Re: [PATCH RESEND] tty: serial: qcom-geni-serial: Poll primary sequencer irq status after cancel_tx

[Vijaya Krishna Nivarthi]

Thank you very much, Hugo Villeneuve and Bjorn, for the review and time.

If this one doesn't get merged, I will post another patch series incorporating suggestions (including splitting) along with few more changes.

-Vijay/



On 8/10/2023 8:06 PM, Bjorn Andersson wrote:
> On Wed, Aug 09, 2023 at 10:51:54PM +0530, Vijaya Krishna Nivarthi wrote:
> > Hi,
> >
> > Thank you very much for the review...
> Thank you for the bug fix, Vijaya.
>
> > On 8/9/2023 6:49 PM, Hugo Villeneuve wrote:
> > > On Wed,  9 Aug 2023 17:41:40 +0530
> > > Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx> wrote:
> > >
> > > > TX is handled by primary sequencer. After cancelling primary command, poll
> > > > primary sequencer's irq status instead of that of secondary.
> > > Hi,
> > > it is not clear to me if this is a bug fix or an improvement?
> > This is a bug fix.
> Please describe the actual problem you're solving, to allow others
> working in and around this driver to know what issue(s) are corrected.
>
> This will save others debugging time, and it will teach others to help
> you maintain this driver.
>
> The section in the documentation on how to describe your changes is
> good, please read it:
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
>
> > > > While at it, also remove a couple of redundant lines that read from IRQ_EN
> > > > register and write back same.
> > > This should go into a separate patch.
> > The changes were too close by so I wasn't sure it could be split into 2
> > patches.
> >
> > I see that the earlier patch has already been signed off by Greg. (I did a
> > RESEND after realising that I had Bjorn Andersson's email address incorrect)
> Please use ./scripts/get_maintainer.pl on the upstream tree, as this
> uses up to date information about recipients.
>
> > Will post another version if original patch doesn't get merged for any
> > reason.
> Please double check linux-next [1], if it's unclear if Greg picked up
> your previous patch (he's usually quite explicit about it...). I really
> would like some more details on the bug fix...
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/
>
> Regards,
> Bjorn