Re: [PATCH v3 1/2] scsi: ufs: core: convert to dev_err_probe() in hba_init
From: Bart Van Assche
Date: Mon Aug 14 2023 - 15:32:23 EST
On 8/14/23 11:43, Brian Masney wrote:
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 129446775796..409d176542e1 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -9235,8 +9235,9 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba)
err = ufshcd_vops_init(hba);
if (err)
- dev_err(hba->dev, "%s: variant %s init failed err %d\n",
- __func__, ufshcd_get_var_name(hba), err);
+ dev_err_probe(hba->dev, err,
+ "%s: variant %s init failed err %d\n",
+ __func__, ufshcd_get_var_name(hba), err);
out:
return err;
}
This opportunity could have been used to improve the grammar of the reported
error message. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>