Re: [Patch net, v2] net: xfrm: skip policies marked as dead while reinserting policies

From: Florian Westphal
Date: Tue Aug 15 2023 - 02:07:29 EST


Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> > dir = xfrm_policy_id2dir(policy->index);
> > - if (policy->walk.dead || dir >= XFRM_POLICY_MAX)
> > + if (dir >= XFRM_POLICY_MAX)
>
> This change is unnecessary, previous code was perfectly fine.

Are you sure? AFAICS walker struct has no 'index' member.