Re: [PATCH 3/3] mm,thp: fix smaps THPeligible output alignment
From: Alexey Dobriyan
Date: Tue Aug 15 2023 - 10:28:40 EST
On Mon, Aug 14, 2023 at 01:02:08PM -0700, Hugh Dickins wrote:
> Swap: 0 kB
> SwapPss: 0 kB
> Locked: 0 kB
> THPeligible: 0
> ProtectionKey: 0
> - seq_printf(m, "THPeligible: %d\n",
> + seq_printf(m, "THPeligible: %8u\n",
> hugepage_vma_check(vma, vma->vm_flags, true, false, true));
Why format string change? It would only slow down printing.
I'd print with
"%u", +hugepage_vma_check()
or just add whitespace.