Re: [PATCH V2 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion.

[Mario Limonciello]

On 8/15/2023 01:15, Meng Li wrote:
> Drop CPU_SUP_INTE from SCHED_MC_PRIO, and it can be used by X86_AMD_PSTATE.

s/CPU_SUP_INTE/CPU_SUP_INTEL/

Also I think this should have a wider description.

Something like:

"amd-pstate also uses SCHED_MC_PRIO, so decouple the requirement
of CPU_SUP_INTEL from the dependencies to allow compilation in kernels 
without Intel CPU support."

> Signed-off-by: Meng Li <li.meng@xxxxxxx>
> ---
>   arch/x86/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index e36261b4ea14..03322d2840fa 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1052,8 +1052,9 @@ config SCHED_MC
>   
>   config SCHED_MC_PRIO
>   	bool "CPU core priorities scheduler support"
> -	depends on SCHED_MC && CPU_SUP_INTEL
> +	depends on SCHED_MC
>   	select X86_INTEL_PSTATE
> +	select X86_AMD_PSTATE

Thinking about it further I wonder if what we actually want is
something like this:

select X86_INTEL_PSTATE if CPU_SUP_INTEL
select X86_INTEL_PSTATE if CPU_SUP_AMD

Then it will work functionally the same for Intel systems
but now you can compile the kernel with support for one
or both and get the right combination included.

>   	select CPU_FREQ
>   	default y
>   	help