[RFC 10/12] arm_mpam: resctrl: Facilitate writing downstream priority value

From: Amit Singh Tomar
Date: Tue Aug 15 2023 - 11:29:16 EST


This change provides a way to write downstream priority value (passed from
schemata file) to arch specific resource control code. The priority value
is stored in mpam_config structure, and eventually gets programmed into
MPAMCFG_PRI register.

Signed-off-by: Amit Singh Tomar <amitsinght@xxxxxxxxxxx>
---
drivers/platform/mpam/mpam_devices.c | 4 ----
drivers/platform/mpam/mpam_resctrl.c | 27 +++++++++++++++++----------
2 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/drivers/platform/mpam/mpam_devices.c b/drivers/platform/mpam/mpam_devices.c
index 137cbff925ba..c0c83c04c77c 100644
--- a/drivers/platform/mpam/mpam_devices.c
+++ b/drivers/platform/mpam/mpam_devices.c
@@ -2351,10 +2351,6 @@ int mpam_apply_config(struct mpam_component *comp, u16 partid,

lockdep_assert_cpus_held();

- if (!memcmp(&comp->cfg[partid], cfg, sizeof(*cfg)))
- return 0;
-
- comp->cfg[partid] = *cfg;
arg.comp = comp;
arg.partid = partid;

diff --git a/drivers/platform/mpam/mpam_resctrl.c b/drivers/platform/mpam/mpam_resctrl.c
index dc710c90cfc2..ffd0fa84d37d 100644
--- a/drivers/platform/mpam/mpam_resctrl.c
+++ b/drivers/platform/mpam/mpam_resctrl.c
@@ -919,7 +919,7 @@ int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_domain *d,
{
int err;
u32 partid;
- struct mpam_config cfg;
+ struct mpam_config *cfg;
struct mpam_props *cprops;
struct mpam_resctrl_res *res;
struct mpam_resctrl_dom *dom;
@@ -934,6 +934,7 @@ int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_domain *d,
cprops = &res->class->props;

partid = resctrl_get_config_index(closid, t);
+ cfg = &dom->comp->cfg[partid];
if (!r->alloc_capable || partid >= resctrl_arch_get_num_closid(r))
return -EINVAL;

@@ -941,17 +942,22 @@ int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_domain *d,
case RDT_RESOURCE_L2:
case RDT_RESOURCE_L3:
/* TODO: Scaling is not yet supported */
- cfg.cpbm = cfg_val;
- mpam_set_feature(mpam_feat_cpor_part, &cfg);
+ if (r->dspri_store) {
+ cfg->dspri = cfg_val;
+ mpam_set_feature(mpam_feat_dspri_part, cfg);
+ } else {
+ cfg->cpbm = cfg_val;
+ mpam_set_feature(mpam_feat_cpor_part, cfg);
+ }
break;
case RDT_RESOURCE_MBA:
if (mba_class_use_mbw_part(cprops)) {
- cfg.mbw_pbm = percent_to_mbw_pbm(cfg_val, cprops);
- mpam_set_feature(mpam_feat_mbw_part, &cfg);
+ cfg->mbw_pbm = percent_to_mbw_pbm(cfg_val, cprops);
+ mpam_set_feature(mpam_feat_mbw_part, cfg);
break;
} else if (mpam_has_feature(mpam_feat_mbw_max, cprops)) {
- cfg.mbw_max = percent_to_mbw_max(cfg_val, cprops);
- mpam_set_feature(mpam_feat_mbw_max, &cfg);
+ cfg->mbw_max = percent_to_mbw_max(cfg_val, cprops);
+ mpam_set_feature(mpam_feat_mbw_max, cfg);
break;
}
fallthrough;
@@ -965,15 +971,15 @@ int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_domain *d,
*/
if (mpam_resctrl_hide_cdp(r->rid)) {
partid = resctrl_get_config_index(closid, CDP_CODE);
- err = mpam_apply_config(dom->comp, partid, &cfg);
+ err = mpam_apply_config(dom->comp, partid, cfg);
if (err)
return err;

partid = resctrl_get_config_index(closid, CDP_DATA);
- return mpam_apply_config(dom->comp, partid, &cfg);
+ return mpam_apply_config(dom->comp, partid, cfg);

} else {
- return mpam_apply_config(dom->comp, partid, &cfg);
+ return mpam_apply_config(dom->comp, partid, cfg);
}
}

@@ -998,6 +1004,7 @@ int resctrl_arch_update_domains(struct rdt_resource *r, u32 closid)
cfg->new_ctrl);
if (err)
return err;
+ cfg->have_new_ctrl = false;
}
}

--
2.25.1