Re: [PATCH v5 6/6] iio: adc: mcp3911: add support for the whole MCP39xx family

[Andy Shevchenko]

On Mon, Aug 14, 2023 at 02:10:10PM +0200, Marcus Folkesson wrote:
> Microchip does have many similar chips, add support for those.
> 
> The new supported chips are:
>   - microchip,mcp3910
>   - microchip,mcp3912
>   - microchip,mcp3913
>   - microchip,mcp3914
>   - microchip,mcp3918
>   - microchip,mcp3919

...

>  	struct {
> -		u32 channels[MCP3911_NUM_CHANNELS];
> +		u32 channels[MCP39XX_MAX_NUM_CHANNELS];
>  		s64 ts __aligned(8);

Can we actually have the __aligned_s64 defined?

Rhetorical... Let me send a patch for that as it's not related to this series.

>  	} scan;

...

> +	/* Enable offset*/

Missing space.

...

> +static int mcp3911_get_osr(struct mcp3911 *adc, u32 *val)
> +{
> +	int ret, osr;
> +
> +	ret = mcp3911_read(adc, MCP3911_REG_CONFIG, val, 2);
> +	if (ret)
> +		return ret;
> +
> +	osr = FIELD_GET(MCP3911_CONFIG_OSR, *val);
> +	*val = 32 << osr;

> +	return ret;

	return 0;

> +}

...

>  {
> -	struct device *dev = &adc->spi->dev;
>  	u32 regval;
>  	int ret;

> +	struct device *dev = &adc->spi->dev;

Stray change.

...

> +	/* Disable offset to ignore any old values in offset register*/

Missing space.

...

> +	u32 regval;
> +	int ret;
> +	struct device *dev = &adc->spi->dev;

Make the longer line first.

...

> +		dev_dbg(dev,
> +			"use internal voltage reference (1.2V)\n");

One line.

...

> +		dev_dbg(dev,
> +			"use crystal oscillator as clocksource\n");

Ditto.

(This is the outcome of the exercise with temporary dev variable)

...

> +	ret = device_property_read_u32(dev, "microchip,device-addr", &adc->dev_addr);
>  	if (ret)
> -		return ret;
> +		device_property_read_u32(dev, "device-addr", &adc->dev_addr);
> +	if (adc->dev_addr > 3) {

> +		dev_err_probe(dev, -EINVAL,
> +			"invalid device address (%i). Must be in range 0-3.\n",
> +			adc->dev_addr);

Missing return?

		return dev_err_probe(...);

> +	}
> +	dev_dbg(dev, "use device address %i\n", adc->dev_addr);

-- 
With Best Regards,
Andy Shevchenko