Re: [PATCH] lsm: constify the 'file' parameter in security_binder_transfer_file()

From: Paul Moore
Date: Tue Aug 15 2023 - 16:05:33 EST


On Aug 12, 2023 Khadija Kamran <kamrankhadijadj@xxxxxxxxx> wrote:
>
> SELinux registers the implementation for the "binder_transfer_file"
> hook. Looking at the function implementation we observe that the
> parameter "file" is not changing.
>
> Mark the "file" parameter of LSM hook security_binder_transfer_file() as
> "const" since it will not be changing in the LSM hook.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@xxxxxxxxx>
> ---
> include/linux/lsm_hook_defs.h | 2 +-
> include/linux/security.h | 4 ++--
> security/security.c | 2 +-
> security/selinux/hooks.c | 8 ++++----
> 4 files changed, 8 insertions(+), 8 deletions(-)

Looks good to me, merged into lsm/next, thanks!

--
paul-moore.com