Re: [PATCH v3 2/3] dt-bindings: leds: Document pull-up supply for interrupt and I2C

From: Krzysztof Kozlowski
Date: Tue Aug 15 2023 - 16:34:19 EST


On 15/08/2023 19:21, Stephan Gerhold wrote:
> Since the interrupt and I2C lines of AW2013 operate in open drain low
> active mode a pull-up supply is needed for correct operation.
> Unfortunately there is no ideal place to describe it in the DT: The
> pull-up needed for the I2C lines could be described on the I2C bus.
> However, the pull-up needed for the interrupt line belongs neither
> directly to the interrupt controller nor to AW2013. Since the AW2013
> driver will be typically in control of the power management and
> interrupt masking it makes more sense to describe it inside the AW2013
> device tree node.
>
> Add it to the AW2013 DT schema together with a comment that makes it
> clear what exactly it represents.
>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof