Re: [PATCH v3] mm: zswap: multiple zpools support

[Chris Li]

Hi Yosry,

Sure.

Ack-by: Chris Li (Google) <chrisl@xxxxxxxxxx>

Chris

On Tue, Aug 15, 2023 at 3:30 PM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote:
>
> I was hoping we can add the basic support here for multiple zpools,
> and then later, if needed, extend to support runtime dynamic tuning.
> Adding this will introduce more complexity as we will need to lock all
> trees and make sure there is no activity and alloc/free zpools. If a
> limitation for compile-time constant is observed we can do that,
> otherwise let's keep it simple and incremental for now.
>
> FWIW, we have been running with 32 zpools in Google's fleet for ~a
> decade now and it seems to work well for various workloads and machine
> configurations.
>
> >
> > Chris
> >
> > > has seen a ton of testing. I was hoping Johannes would get time to
> > > take a look, or Nhat would get time to test it out, but neither of
> > > these things happen.
> > >
> > > I obviously want it to be merged, but hopefully someone will chime in here :)
> > >
>