RE: [EXT] Re: [PATCH v1 net] octeontx2-pf: fix page_pool creation fail for rings > 32k

[Ratheesh Kannoth]

> From: Jesper Dangaard Brouer <hawk@xxxxxxxxxx>
> Sent: Tuesday, August 15, 2023 2:12 PM
> To: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> Subject: [EXT] Re: [PATCH v1 net] octeontx2-pf: fix page_pool creation fail
> for rings > 32k
> 
>   These pages are pinned down over time as working sets varies, due to
>   the recycling nature of page pool, given page pool (currently) don't
>   have a shrinker mechanism, the pages remain pinned down in ptr_ring.

ACK

> 
> > As page pool does direct
> > recycling way more aggressivelyi, often times ptr_ring is left
>                                   ^
> Typo
> (my suggestion already covers recycling)
ACK, will remove this line.

> > unused at all. Instead of clamping page_pool size to 32k at most,
> > limit it even more to 2k to avoid wasting memory on much less used
> > ptr_ring.
> 
> I would adjust and delete "much less used".
ACK

> And then produce a statement in the commit desc like:
> 
>   This have been tested on octeontx2 hardware (devel board xyz).
>   TCP and UDP tests using netperf shows not performance regressions.
Let me do more testing and get back.