Re: [PATCH 1/4] dt-bindings: clock: qcom: Add ECPRICC clocks for QDU1000 and QRU1000

[Krzysztof Kozlowski]

On 08/08/2023 07:14, Imran Shaik wrote:
> Add device tree bindings for qcom ecpri clock controller on QDU1000 and
> QRU1000 SoCs.
> 
> Signed-off-by: Imran Shaik <quic_imrashai@xxxxxxxxxxx>
> ---
>  .../bindings/clock/qcom,qdu1000-ecpricc.yaml  |  68 +++++++
>  .../dt-bindings/clock/qcom,qdu1000-ecpricc.h  | 192 ++++++++++++++++++
>  2 files changed, 260 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml
>  create mode 100644 include/dt-bindings/clock/qcom,qdu1000-ecpricc.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml
> new file mode 100644
> index 000000000000..db54052bf360
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,qdu1000-ecpricc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm ECPRI Clock & Reset Controller for QDU1000 and QRU1000
> +
> +maintainers:
> +  - Taniya Das <quic_tdas@xxxxxxxxxxx>
> +  - Imran Shaik <quic_imrashai@xxxxxxxxxxx>
> +
> +description: |
> +  Qualcomm ecpri clock control module which supports the clocks, resets
> +  on QDU1000 and QRU1000
> +
> +  See also:: include/dt-bindings/clock/qcom,qdu1000-ecpricc.h
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,qdu1000-ecpricc
> +
> +  clocks:
> +    items:
> +      - description: Board XO source
> +      - description: GPLL0 source from GCC
> +      - description: GPLL1 source from GCC
> +      - description: GPLL2 source from GCC
> +      - description: GPLL3 source from GCC
> +      - description: GPLL4 source from GCC
> +      - description: GPLL5 source from GCC
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  '#reset-cells':
> +    const: 1
> +
> +  reg:
> +    maxItems: 1

Keep the same order as in required: below.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof