Re: [PATCH] i2c: Make I2C_ATR invisible

[Geert Uytterhoeven]

Hi Tomi,

On Tue, Aug 15, 2023 at 6:00 PM Tomi Valkeinen
<tomi.valkeinen@xxxxxxxxxxxxxxxx> wrote:
> On 15/08/2023 18:29, Geert Uytterhoeven wrote:
> > I2C Address Translator (ATR) support is not a stand-alone driver, but a
> > library.  All of its users select I2C_ATR.  Hence there is no need for
> > the user to enable this symbol manually, except when compile-testing.
> >
> > Fixes: a076a860acae77bb ("media: i2c: add I2C Address Translator (ATR) support")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> > Do we care yet about out-of-tree drivers that need this functionality?
> > ---
> >   drivers/i2c/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> > index c6d1a345ea6d8aee..9388823bb0bb960c 100644
> > --- a/drivers/i2c/Kconfig
> > +++ b/drivers/i2c/Kconfig
> > @@ -72,7 +72,7 @@ config I2C_MUX
> >   source "drivers/i2c/muxes/Kconfig"
> >
> >   config I2C_ATR
> > -     tristate "I2C Address Translator (ATR) support"
> > +     tristate "I2C Address Translator (ATR) support" if COMPILE_TEST
> >       help
> >         Enable support for I2C Address Translator (ATR) chips.
> >
>
> Isn't this normally done with just "tristate", without the text? Is
> there a need to make configs manually selectable when compile-test is
> enabled?

"tristate" without the text would make the symbol invisible, too.
However, then the user has no way to enable it for compile-testing
(unless also enabling one of the symbols that select it, which may
 not be possible due to other dependencies).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds