Re: [PATCH v1 1/1] gpiolib: sysfs: Do unexport GPIO when user asks for it

[Bartosz Golaszewski]

On Mon, Aug 14, 2023 at 6:29 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Mon, Aug 14, 2023 at 7:13 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > On Mon, Aug 14, 2023 at 1:19 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > >
> > > It seems that sysfs interface implicitly relied on the gpiod_free()
> > > to unexport the line. This is not good and prone to regressions.
> > > Fix it by explicitly calling gpiod_unexport().
> > >
> >
> > I wouldn't say it's prone to regressions, it's literally just that
> > gpiod_free() should not deal with sysfs.
> >
> > How about that for commit message (I can change it when applying):
> >
> > It seems that sysfs interface implicitly relied on the gpiod_free()
> > to unexport the line. This is logically incorrect as core gpiolib should
> > not deal with sysfs so instead of restoring it, let's call gpiod_unexport()
> > from sysfs code.
>
> I'm fine with it, go ahead and apply with the change. Thank you!
>
> --
> With Best Regards,
> Andy Shevchenko

Queued for fixes.

Bart