Re: [PATCH v3 10/12] PM: EM: Add runtime update interface to modify EM power

[Dietmar Eggemann]

On 21/07/2023 17:50, Lukasz Luba wrote:

[...]

> @@ -381,6 +383,12 @@ static inline int em_pd_nr_perf_states(struct em_perf_domain *pd)
>  {
>  	return 0;
>  }
> +static inline
> +int em_dev_update_perf_domain(struct device *dev, struct em_data_callback *cb,
> +			      void *priv)
> +{
> +	return -EINVAL;
> +}
>  #endif
>  
>  #endif
> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
> index 4596bfe7398e..10180c776c5b 100644
> --- a/kernel/power/energy_model.c
> +++ b/kernel/power/energy_model.c
> @@ -185,6 +185,101 @@ static int em_compute_costs(struct device *dev, struct em_perf_state *table,
>  	return 0;
>  }
>  
> +/**
> + * em_dev_update_perf_domain() - Update run-time EM table for a device

nit pick: s/run-time/runtime

there are multiple occurrences in this file (maybe more in the entire set?)

[...]