Re: [PATCH 10/17] zorro: include zorro.h in names.c

[Geert Uytterhoeven]

On Thu, Aug 10, 2023 at 4:22 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The zorro_name_device() function is defined in drivers/zorror/names.c, but
> the declaration is not visible there:
>
> drivers/zorro/names.c:58:13: error: no previous prototype for 'zorro_name_device' [-Werror=missing-prototypes]
>    58 | void __init zorro_name_device(struct zorro_dev *dev)
>
> Include the header to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. will queue in the m68k for-v6.6 branch, with the "zorror" typo fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds