Re: [PATCH] selftests/futex: Order calls to futex_lock_pi

From: Shuah Khan
Date: Wed Aug 16 2023 - 12:54:04 EST


On 8/14/23 02:09, Nysal Jan K.A wrote:
Observed occassional failures in the futex_wait_timeout test:

ok 1 futex_wait relative succeeds
ok 2 futex_wait_bitset realtime succeeds
ok 3 futex_wait_bitset monotonic succeeds
ok 4 futex_wait_requeue_pi realtime succeeds
ok 5 futex_wait_requeue_pi monotonic succeeds
not ok 6 futex_lock_pi realtime returned 0
......

The test expects the child thread to complete some steps before
the parent thread gets to run. There is an implicit expectation
of the order of invocation of futex_lock_pi between the child thread
and the parent thread. Make this order explicit. If the order is
not met, the futex_lock_pi call in the parent thread succeeds and
will not timeout.

Fixes: f4addd54b161 ("selftests: futex: Expand timeout test")
Signed-off-by: Nysal Jan K.A <nysal@xxxxxxxxxxxxx>
---

Thank you. Applied to linux-kselftest next for Linux 6.6-rc1.

thanks,
-- Shuah