Re: [PATCH v3 2/4] firmware: qcom_scm: disable SDI if required

From: Guru Das Srinagesh
Date: Wed Aug 16 2023 - 13:03:47 EST


On Aug 16 2023 18:45, Robert Marko wrote:
> IPQ5018 has SDI (Secure Debug Image) enabled by TZ by default, and that
> means that WDT being asserted or just trying to reboot will hang the board
> in the debug mode and only pulling the power and repowering will help.
> Some IPQ4019 boards like Google WiFI have it enabled as well.
>
> Luckily, SDI can be disabled via an SCM call.
>
> So, lets use the boolean DT property to identify boards that have SDI
> enabled by default and use the SCM call to disable SDI during SCM probe.
> It is important to disable it as soon as possible as we might have a WDT
> assertion at any time which would then leave the board in debug mode,
> thus disabling it during SCM removal is not enough.
>
> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>

Reviewed-by: Guru Das Srinagesh <quic_gurus@xxxxxxxxxxx>