Re: [PATCH v1 03/14] media: qcom: camss: Drop useless NULL assignment for ispif resources

From: Bryan O'Donoghue
Date: Wed Aug 16 2023 - 15:07:37 EST


On 16/08/2023 18:10, Konrad Dybcio wrote:
On 14.08.2023 18:28, Bryan O'Donoghue wrote:
The NULL pointer assignement is a redundant step our compiler will
initialize unpopulated fields as zero. We check for logical ! later on
in the code as opposed to NULL anyway.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
---
Just squash it with patch 2?

Konrad

Yeah but this is zapping an unnecessary NULL, the other patch is about condensing down into one common structure. I kind of prefer to keep as much granularity as possible.

---
bod